Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rikudou/iban #1

Closed
RikudouSage opened this issue Mar 30, 2022 · 2 comments
Closed

Use rikudou/iban #1

RikudouSage opened this issue Mar 30, 2022 · 2 comments

Comments

@RikudouSage
Copy link

RikudouSage commented Mar 30, 2022

Instead of the bundled implementation, you could use the decoupled rikudou/iban and optionally provide an implementation of the interface for some local format.

Also you may move your Hungarian adapter from this package to the rikudou/iban package to make it available even in contexts outside QR payments.

@hubipe
Copy link
Owner

hubipe commented Mar 30, 2022

Thanks, I've decoupled the IBAN interface (f792d27).

Concerning the Hungarian adapter, I have it prepared, but have to write some tests firsts (hopefully will pull-request it by end of the week).

@hubipe
Copy link
Owner

hubipe commented Apr 8, 2022

Bundled implementation of the Hungarian IBAN adapter and validator successfully moved to rikudou/IBAN, thus closing the issue.

@hubipe hubipe closed this as completed Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants