Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider panicking when nest would overwrite resources #87

Open
aturon opened this issue Nov 27, 2018 · 1 comment
Open

Consider panicking when nest would overwrite resources #87

aturon opened this issue Nov 27, 2018 · 1 comment
Labels
design Open design question

Comments

@aturon
Copy link
Collaborator

aturon commented Nov 27, 2018

Right now, calling nest on a route that already has resources causes those resources to be silently dropped, which seems problematic. We should either figure out a reasonable way to "merge" with existing resources (I'm skeptical this would work out), or just panic in such a case.

Panicking in app construction is generally OK since even trivial testing will reveal the problem.
@aturon aturon added the design Open design question label Nov 27, 2018
@aturon
Copy link
Collaborator Author

aturon commented Apr 10, 2019

Even after #156 the story here is a bit muddy. We should consider making improvements to route-recognizer such that we can tell when an existing resource is being overwritten.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design Open design question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aturon