Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Rename App #75

Closed
skade opened this issue Nov 26, 2018 · 2 comments
Closed

Proposal: Rename App #75

skade opened this issue Nov 26, 2018 · 2 comments
Labels
design Open design question

Comments

@skade
Copy link
Contributor

skade commented Nov 26, 2018

Currently, the App object is a mix between a builder (it's the interface to globally manipulating the router) and can be turned into_server and a global entry point into building something that can be called into. I'm not sure if App is a good name for it.

Mainly, it collides with a frequent usage of App in other frameworks, for example, Django uses App four a mountable subapp (basically a collection of endpoints). https://docs.djangoproject.com/en/2.1/ref/settings/#installed-apps

@aturon aturon added the design Open design question label Nov 27, 2018
@aturon
Copy link
Collaborator

aturon commented Nov 27, 2018

Related: do we want to do something more sophisticated with the current "app" concept, like mountable sub-apps and/or the ability to map functions over the application state as you descend the router?

@petejodo petejodo mentioned this issue Jan 22, 2019
8 tasks
@aturon
Copy link
Collaborator

aturon commented Apr 10, 2019

With the #156 revamp, we do intend to allow Apps to be nested; that desire is tracked in #160. I'm closing this issue for the time being.

@aturon aturon closed this as completed Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Open design question
Projects
None yet
Development

No branches or pull requests

2 participants