Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI doesn't handle feature flags with workspace #226

Closed
Nemo157 opened this issue May 15, 2019 · 0 comments · Fixed by #228
Closed

CI doesn't handle feature flags with workspace #226

Nemo157 opened this issue May 15, 2019 · 0 comments · Fixed by #228

Comments

@Nemo157
Copy link
Contributor

Nemo157 commented May 15, 2019

Correctly testing feature flags in workspaces is hard. The current CI setup doesn't handle this appropriately. For some of the issues you could look at how complicated the futures workspaces .travis.yml is and its history.

I'll try and port some of the simpler ideas from the futures setup across here so that as more feature flags are added basic compatibility can be tested (actually exhaustively testing feature flags becomes impossible quickly because there are O(n!) combinations, but with just a few extra builds you can test for the most likely issues).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant