You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@yawnt found a few minor things when I was using this extensively:
EventEmitter3 will not throw on an unhandled error: but without any default handler it's very confusing to debug when your proxy logic is just plain wrong. We should have a default logger if there are no error handlers. cc/ @3rd-Eden
We should have a simple(r) .createProxy() method: which is basically just exposing createRightProxy. A lot of our users don't even bother with httpProxy.createServer, they just use new httpProxy.RoutingProxy(). Forcing them to create a server that they will never use feels very awkward.
Remove all (soon to be old) caronte links: The README.md and a few other doc links still have hrefs to the caronte branch
The text was updated successfully, but these errors were encountered:
@indexzero running httpProxy.createServer() actually just creates a proxy. The only thing that makes it a "server" is by calling the .listen() method. This is one of the reasons I exposed the "server" on the main module.exports so you can just do..
@yawnt found a few minor things when I was using this extensively:
error
: but without any default handler it's very confusing to debug when your proxy logic is just plain wrong. We should have a default logger if there are noerror
handlers. cc/ @3rd-Eden.createProxy()
method: which is basically just exposingcreateRightProxy
. A lot of our users don't even bother withhttpProxy.createServer
, they just usenew httpProxy.RoutingProxy()
. Forcing them to create a server that they will never use feels very awkward.caronte
branchThe text was updated successfully, but these errors were encountered: