autoRewrite is broken in 1.16

[apalchys]

It seems the following commit introduces a bug and "autoRewite" doesn't work properly now: 4edbb62

Method setRedirectHostRewrite changes "location" header, but writeHeaders ignores it and uses rawHeaders instead of headers

[jcrugzz]

@apalchys could you give some more information on whats not working? what changed in the expectations? I apologize if all the conditions were not covered but the same logic is being run but is the value of the header not what is expected?

[apalchys]

@jcrugzz you can find more details in a PR opened by @pachirel #1104

[pachirel]

I have not tried to reproduce this issue yet. Any additional information are welcome. :)

[apalchys]

@pachirel your PR looks good and should fix autoRewrite because it doesn't overwrite header value. thanks.

[pachirel]

@apalchys 1.16.2 is available. please update and check your app. thanks to @jcrugzz.

[myfancypants]

I don't know if this would be the right place for feedback but in lib/http-proxy/passes/web-outgoing.js

res.setHeader('Set-Cookie', setCookies.length === 1 ? setCookies[0] : setCookies);

from 1.16.1 prior to the roll back was a breaking change. Our tooling was expecting a consistent array of cookies returned. The return of a string or an array was causing everything to break. Working locally and simply returning

res.setHeader('Set-Cookie', setCookies);

got us back up and operational.

I don't know if this impacts autoRewrite specifically, but figured I could provide some feedback on my own investigations into the matter

[apalchys]

@pachirel it works now. thanks a lot!