From f5e1844abd6f7a62d196025e126b6c3fbdbf34ac Mon Sep 17 00:00:00 2001 From: Raynos Date: Fri, 10 May 2013 17:55:01 -0600 Subject: [PATCH] Pass default certs to SNICallback example Using only SNICallback to create a HTTPS / TLS server is bad. It means all non SNI clients can't do anything because there are no certs. in v0.10 of node TLS server was updated to throw if you forgot to supply certs. Which means that every HTTPS server needs to supply certs as a fallback for when SNI is not available. - closes #399 --- README.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 770a033ee..a7a8328c0 100644 --- a/README.md +++ b/README.md @@ -345,7 +345,10 @@ var options = { https: { SNICallback: function (hostname) { return certs[hostname]; - } + }, + cert: myCert, + key: myKey, + ca: [myCa] }, hostnameOnly: true, router: {