Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--cors usage is incorrect in the documentation #856

Open
sandeep-vedam opened this issue Apr 17, 2023 · 1 comment · May be fixed by #857
Open

--cors usage is incorrect in the documentation #856

sandeep-vedam opened this issue Apr 17, 2023 · 1 comment · May be fixed by #857
Labels

Comments

@sandeep-vedam
Copy link

sandeep-vedam commented Apr 17, 2023

--cors | Enable CORS via the Access-Control-Allow-Origin header
The above documentation seems to be incorrect and it is confusing. As we can see through the code, that --cors will enable the Access-Control-Allow-Origin header and also the value set is assigned to the Access-Control-Allow-Headers . Possible values: should be like here --cors='X-Custom-Header'

Here is the line that supports above:
https://github.com/http-party/http-server/blob/master/lib/http-server.js#L101-L107

@sandeep-vedam sandeep-vedam linked a pull request Apr 17, 2023 that will close this issue
2 tasks
@github-actions
Copy link

This issue has been inactive for 180 days

@github-actions github-actions bot added the stale label Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant