Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typeof typeof noUiSlider causes require is not defined bug #476

Closed
NikarashiHatsu opened this issue Oct 7, 2024 · 8 comments
Closed

typeof typeof noUiSlider causes require is not defined bug #476

NikarashiHatsu opened this issue Oct 7, 2024 · 8 comments
Labels
bug Something isn't working

Comments

@NikarashiHatsu
Copy link

Summary

Double typeof keyword causes require is not defined bug

Steps to Reproduce

  1. Install Preline on a fresh Laravel project using this guide.
  2. Build the asset using npm run build or bun run build.
  3. See the error such as screenshot below:
Screenshot 2024-10-07 at 15 40 54 Screenshot 2024-10-07 at 15 41 02

My current workaround is downgrading to 2.4.0 or editing the package file to remove the extra typeof.

Please let me know if this is intended, or a typo, since I'm not an expert into JavaScript.

Demo Link

https://github.com/NikarashiHatsu/preline-typeof-bug

Expected Behavior

There are no require is not defined error on the console.

Actual Behavior

The error require is not defined is exists on compiled asset of Preline.

Screenshots

Screenshot 2024-10-07 at 15 40 54 Screenshot 2024-10-07 at 15 41 02

On line 50
Screenshot 2024-10-07 at 15 53 04

@TheBous
Copy link

TheBous commented Oct 7, 2024

same issue here

@matteotumiati
Copy link

There's PR #471 that should fix this, and we're waiting to get merged when 2.5.1 will be released 😄

@NikarashiHatsu
Copy link
Author

@matteotumiati classic silly copy-paste predicament 😅

@Sicklou
Copy link

Sicklou commented Oct 10, 2024

This issue completely broke my production. Hopefully the fix comes quick

@jahaganiev jahaganiev added the bug Something isn't working label Oct 13, 2024
@andrew-vdb
Copy link

losing hours of my life because of this issue (in the weekend with flue)... i'll wait 2.5.1 to be released...

@rubenrcdev
Copy link

3 weeks to merge a fix with one line change...
Why a bug, that break the compilation and not allow to deploy it, that must be a priority fix, can be standby for a 3 weeks?

@mstnorris
Copy link

When is the v2.5.1 release due to go out?

@jahaganiev
Copy link
Member

Hey everyone!

The v2.5.1 release with important fixes is now live. We sincerely apologize for the delay in rolling out this hotfix update.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

8 participants