Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Gutenbeg Editor Styles #47

Closed
yumyo opened this issue Apr 30, 2020 · 1 comment
Closed

Add support for Gutenbeg Editor Styles #47

yumyo opened this issue Apr 30, 2020 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@yumyo
Copy link

yumyo commented Apr 30, 2020

Expected behaviour

Editor styles are correcting recognised, transformed and inlined by Gutenberg.

Actual behaviour

Editor styles are not recognised so the default styles are inlined instead.
This cause having to rely on unnecessary CSS !important rules or additional selectors.

Comments

Solved by commenting out the current editor.css enqueue in app/helpers/assets.php in favour of adding:

/**
 * Support the theme’s editor styles.
 *
 * @link https://developer.wordpress.org/block-editor/developers/themes/theme-support/#editor-styles
 */

add_theme_support( 'editor-styles' );
add_editor_style(  '../dist/styles/editor.css');

to app/setup/theme-support.php

@atanas-dev atanas-dev self-assigned this Apr 30, 2020
@atanas-dev atanas-dev added the bug Something isn't working label Apr 30, 2020
@atanas-dev
Copy link
Contributor

Thank you for the report @yumyo - the issue has been fixed in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants