Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility issue with php 8.3.1 #1217

Closed
rstrah opened this issue Feb 15, 2024 · 5 comments
Closed

Compatibility issue with php 8.3.1 #1217

rstrah opened this issue Feb 15, 2024 · 5 comments

Comments

@rstrah
Copy link

rstrah commented Feb 15, 2024

Version

3.6.3 - Carbon Fields:
6.4.3 - WordPress:
8.3.1 - PHP:

Expected Behavior

No errors like "Calling get_class() without arguments is deprecated"

Actual Behavior

https://prnt.sc/5qPRcRUFP_py

@alvarosego01
Copy link

Hello.

I have the same problem, I solved it by downgrading php to 8.1

@chrismccoy
Copy link

Hello.

I have the same problem, I solved it by downgrading php to 8.1

carbon works with php 8.2, the get_class() needs to be replaced with static::class in 7 diff files. if you really want to use php 8.3

@kwisatz
Copy link
Contributor

kwisatz commented Jul 15, 2024

Why would we not really want to use php8.3 ? ;)

Anyway, I saw there is a PR for this here, wondering if @htmlburger-git will consider that (or an improved version thereof?)

Update

Created #1239 without the flaws of #1223

@atanas-vasilev-dev
Copy link
Collaborator

This was fixed in #1239 and will be added to the next release.

@atanas-vasilev-dev
Copy link
Collaborator

The fix for this issue is now released in https://github.com/htmlburger/carbon-fields/releases/tag/v3.6.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants