Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[glyph] add remaining d3 symbols #84

Merged
merged 3 commits into from
Jun 30, 2017
Merged

[glyph] add remaining d3 symbols #84

merged 3 commits into from
Jun 30, 2017

Conversation

hshoff
Copy link
Member

@hshoff hshoff commented Jun 30, 2017

  • adds support for the missing d3 symbols from d3-shape
  • <GlyphDot /> should be considered deprecated in favor of <GlyphCircle /> for a consistent api across all Glyphs, but I'll keep GlyphDot around just in case folks are already using it as legacy

<GlyphCircle />
screen shot 2017-06-30 at 1 58 44 pm

<GlyphSquare />
screen shot 2017-06-30 at 1 57 12 pm

<GlyphWye />
screen shot 2017-06-30 at 1 53 57 pm

<GlyphTriangle />
screen shot 2017-06-30 at 1 52 43 pm

<GlyphStar />
screen shot 2017-06-30 at 1 50 55 pm

<GlyphCross />
screen shot 2017-06-30 at 2 07 48 pm

@hshoff hshoff added this to the v0.0.124 milestone Jun 30, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.7%) to 26.758% when pulling c51e7e6 on harry-glyphs into 8c96326 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.7%) to 26.758% when pulling c51e7e6 on harry-glyphs into 8c96326 on master.

@hshoff
Copy link
Member Author

hshoff commented Jun 30, 2017

adding glyphs in the custom legend demo
screen shot 2017-06-30 at 2 28 53 pm

@hshoff hshoff merged commit 2a687fe into master Jun 30, 2017
@hshoff hshoff deleted the harry-glyphs branch June 30, 2017 21:30
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.7%) to 26.758% when pulling ef63e98 on harry-glyphs into 8c96326 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants