Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPS through naett: Get the body of the response even if code isn't 200 #18651

Merged
merged 1 commit into from
Dec 31, 2023

Conversation

hrydgard
Copy link
Owner

This is required for rcheevos to parse errors properly - it ignores the error code and parses it out of the body instead.

We should now be able to produce more focused error messages.

…200.

This is required for rcheevos to parse errors properly - it ignores the
error code and parses it out of the body instead.
@hrydgard hrydgard added the RetroAchievements RetroAchievements related work label Dec 30, 2023
@hrydgard hrydgard added this to the v1.17.0 milestone Dec 30, 2023
@hrydgard hrydgard merged commit eabcd5d into master Dec 31, 2023
18 checks passed
@hrydgard hrydgard deleted the https-retroachievement-fix branch December 31, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RetroAchievements RetroAchievements related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant