Defer frame waits if possible #18573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrydgard
force-pushed
the
defer-frame-waits
branch
from
38e88c1
to
e1f1af6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To regulate speed, we insert waits into each frame. Previously, we waited right at the time we hit a vsync and stopped emulating, then continued to the submit phase of the frame, but with this, we submit the accumulated drawing commands to the GPU first, and then wait.
While due to the frame overlap we already have this won't result in a lot of extra performance, it should help latency slightly, especially if the driver is smart or if we add some of the other stuff from #17917 later.
EDIT: For some reason, this seems to have issues on Android. So, draft for now.
EDIT2: With the last commit, it now only has problems when you enable frameskipping fast-forward, and that's not Android-specific..
EDIT3: Fixed the logic, oops.