Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip xinput trigger threshold check #18407

Merged
merged 1 commit into from
Nov 11, 2023

Conversation

Kethen
Copy link
Contributor

@Kethen Kethen commented Nov 11, 2023

Address #18404 , remove the hard coded 30.0f/255.0f deadzone on triggers

It should be fine since analog deadzone was moved to control mapper around 633a6f6

To further address #16643 with analog mapped to digital, I'm guessing KeyMap thresholds should be evaluated (if that still happens), but this should already make it harder for analog triggers mapped to digital buttons to get stuck

ppsspp/Core/KeyMap.h

Lines 81 to 83 in 2036f1c

const float AXIS_BIND_THRESHOLD = 0.75f;
const float AXIS_BIND_RELEASE_THRESHOLD = 0.35f; // Used during mapping only to detect a "key-up" reliably.
const float AXIS_BIND_THRESHOLD_MOUSE = 0.01f;

@hrydgard
Copy link
Owner

Huh, yeah, indeed forgot to remove this old deadzone handling when centralizing.

Should also just get rid of the function NormalizedDeadzoneDiffers, but I'll sneak that into the merge.

@hrydgard hrydgard added the Input/Controller Input and controller issues label Nov 11, 2023
@hrydgard hrydgard merged commit cdd6f2f into hrydgard:master Nov 11, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Input/Controller Input and controller issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants