Don't load the shader cache on a separate thread - all it does is already async #18216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrydgard
force-pushed
the
remove-shader-cache-load-thread
branch
from
c5f0f0c
to
d31ba39
Compare
hrydgard
added a commit
that referenced
this pull request
Sep 24, 2023
hrydgard
added a commit
that referenced
this pull request
Sep 30, 2023
hrydgard
added a commit
that referenced
this pull request
Oct 3, 2023
Simplify disk-cache-load on GLES as well, for the same reasons as #18216
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since some time, all the shader cache load has really done in practice is to spawn asynchronous tasks, so it itself runs really quickly.
Gets rid of a mutex and should remove some additional potential for sync bugs, although I think I fixed most of them in the last PR.
We already have to properly handle shutdown of all the async tasks, no need to add another layer of async-ness and locks.