Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bleach: Soul Carnival [freezing] #1782

Closed
brujo5 opened this issue May 12, 2013 · 39 comments · Fixed by #12160
Closed

Bleach: Soul Carnival [freezing] #1782

brujo5 opened this issue May 12, 2013 · 39 comments · Fixed by #12160
Milestone

Comments

@brujo5
Copy link

brujo5 commented May 12, 2013

all graphics are fixed but again it's 'freezing' at this point(music keep playing)

console image

http://forums.ppsspp.org/attachment.php?aid=4611

http://forums.ppsspp.org/attachment.php?aid=4610

thx.

@unknownbrackets
Copy link
Collaborator

Has this improved at all? Is there a log?

-[Unknown]

@daniel229
Copy link
Collaborator

Still freeze with 0.96-209.

dubug log
https://gist.github.com/daniel229/8167469

@unknownbrackets
Copy link
Collaborator

Hmm. I guess it's waiting for something with audio, not sure...

-[Unknown]

@unknownbrackets
Copy link
Collaborator

I don't suppose this changed at all since the Yu-Gi-Oh fix, which seemed like a similar problem?

-[Unknown]

@daniel229
Copy link
Collaborator

Not fixed yet.

@unknownbrackets
Copy link
Collaborator

Would it be correct for me to assume the hang is similar to Bleach Soul Carnival 2?

#875 (comment)

AFAICT there is no demo for the first one. In any case, I'm thinking it's a pause signal issue.

-[Unknown]

@unknownbrackets
Copy link
Collaborator

Does this sitll happen in Bleach: Soul Carnival 1, as well as 2?

-[Unknown]

@daniel229
Copy link
Collaborator

Still happen,Soul Carnival 1 freezed after pause.Soul Carnival 2 hangs on bootup
debug log(rename jpg to rar)
soul carnival 1
soul carnival 2

@sum2012
Copy link
Collaborator

sum2012 commented Jul 21, 2014

@sum2012
Copy link
Collaborator

sum2012 commented Jul 22, 2014

Infact I have discussed with @unknownbrackets Bleach: Soul Carnival 1 in very long time ago
Using V0.9.8 source with this change work
http://forums.ppsspp.org/showthread.php?tid=9065&pid=71560#pid71560

@sum2012
Copy link
Collaborator

sum2012 commented Jul 22, 2014

But some Android user do not work with this hack.

@hrydgard
Copy link
Owner

Now that BSC2 is in-game, it is also affected by this freeze.

@sum2012
Copy link
Collaborator

sum2012 commented Jul 28, 2014

v0.9.9-37-g682e1c1 .
BSC2 freeze in menu in the picture
1

info log:https://gist.github.com/sum2012/6b35e7f5c429d12cb5b8
Debug log (use save status):
https://gist.github.com/sum2012/ac8279762895380945e6

@sum2012
Copy link
Collaborator

sum2012 commented Jan 20, 2015

Update debug log to v0.9.9.1-1574-gfeeb3c9
https://drive.google.com/file/d/0B3OaSdeV0L8kUWE0azRFS3c3REU/view?usp=sharing

@unknownbrackets
Copy link
Collaborator

What if you apply this ugly hack in Core/HLE/sceSas.cpp?

#include <Windows.h>

static u32 sceSasGetAllEnvelopeHeights(u32 core, u32 heightsAddr) {
    DEBUG_LOG(SCESAS, "sceSasGetAllEnvelopeHeights(%08x, %i)", core, heightsAddr);

    if (!Memory::IsValidAddress(heightsAddr)) {
        return ERROR_SAS_INVALID_PARAMETER;
    }

    for (int i = 0; i < PSP_SAS_VOICES_MAX; i++) {
        int voiceHeight = sas->voices[i].envelope.GetHeight();
        Memory::Write_U32(voiceHeight, heightsAddr + i * 4);
    }

    if (GetAsyncKeyState(VK_DECIMAL)) {
        for (int i = 0; i < PSP_SAS_VOICES_MAX; i++) {
            int voiceHeight = sas->voices[i].envelope.GetHeight();
            NOTICE_LOG(HLE, "Replacing voice height %d of %d with 0", i, voiceHeight);
            Memory::Write_U32(0, heightsAddr + i * 4);
        }
    }

    return 0;
}

When the freeze happens, try pressing the "." key (on the numpad I think.) You can replace with another key if you like, but I'm wondering both: what it logs (what are the heights), and whether forcing it to zero helps.

That should at least answer if it's waiting for a height. You can also try forcing the value to 0x40000000 instead of 0. If neither works then probably it's not waiting on heights.

-[Unknown]

@daniel229
Copy link
Collaborator

log of Bleach: Soul Carnival 2, 0 or 0x40000000 did not help.
https://gist.github.com/daniel229/9202a11960d14a69bc0d

@daniel229
Copy link
Collaborator

Revert back these 2 lines 4561440#commitcomment-6889647 fixes this issue and the Armored Core series

@sum2012
Copy link
Collaborator

sum2012 commented Aug 2, 2015

Update debug log to v1.0.1-799-gb5f7d93
https://drive.google.com/file/d/0B3OaSdeV0L8kcF9EZ3pNdG9uNmc/view?usp=sharing
The GPU sign handling is still wrong

@sum2012
Copy link
Collaborator

sum2012 commented Aug 2, 2015

@heireaper
Copy link

Any way to fix this issue on iOS? Bleach soul carnival still freezes when I talk to rukia. As for bleach soul carnival 2, the game will load but, when I get to rukia it freezes again... Any solution for iOS?

@sum2012
Copy link
Collaborator

sum2012 commented Aug 3, 2015

@brujo5
Copy link
Author

brujo5 commented Aug 13, 2015

@sum2012

do you have an save state after the hang problem (working) for soul carnival 1/2?

@sum2012
Copy link
Collaborator

sum2012 commented Aug 13, 2015

@brujo5
Copy link
Author

brujo5 commented Aug 13, 2015

@sum2012

Thank alot!!

There is a chance that hang again later or only happens at the beginning?

@sum2012
Copy link
Collaborator

sum2012 commented Aug 13, 2015

@brujo5 it will hang again when you return to map,then go to menu.
The only solution is compile ppsspp with the hack change sum2012@07b5c98

(If you compile ok,can you share with me with your ios port of this hack ? Thanks)

@brujo5
Copy link
Author

brujo5 commented Aug 14, 2015

ok,thanks:)

@sum2012
Copy link
Collaborator

sum2012 commented Mar 22, 2016

v1.2.2-176-gb0329e8
GPU sign handling is still wrong
https://drive.google.com/file/d/0B3OaSdeV0L8kX0lLcVZKZDJod2c/view?usp=sharing

@brujo5
Copy link
Author

brujo5 commented Mar 22, 2016

@sum2012

Do you have an apk with the hack change? Thx

@sum2012
Copy link
Collaborator

sum2012 commented Mar 22, 2016

@brujo5 a bit old
http://pan.baidu.com/s/1bs2mEM

@LunaMoo
Copy link
Collaborator

LunaMoo commented Mar 23, 2016

@brujo5 in case you just want to play and missed it - a while ago I made cwcheat version of that hack. It's posted in each of those game's thread ~ here and here - can be used in any ppsspp version on any platform(assuming cwcheats work everywhere).
Note that as long as [Disable] cheat is not used or emulation is restarted, the hack will continue to work even if you completely turn off cheats.

@brujo5
Copy link
Author

brujo5 commented Mar 23, 2016

@sum2012
@LunaMoo

Sorry for delay thank you.

@Trappubot
Copy link

@sum2012 Can you upload a Ppsspp that has the bleach soul carnival menu fix compiled in it?
Tnx

@sum2012
Copy link
Collaborator

sum2012 commented Mar 26, 2016

@m3gaGamer windows 32 bit or windows 64 bit?

@Trappubot
Copy link

64Bit

@Trappubot
Copy link

Oh nvm i figured a way to get pass it using cheats
Thanks for helping anyways

@Darkjuda
Copy link

Darkjuda commented Sep 7, 2016

I'd like to comfirm that the issue is still happening in the latest build (1.2.2-948-g79f1b19), nonetheless the cheats provided by LunaMoo seem to work. They could be added automaticaly to the code as an hack in the options, or, in a more easy way, as regular cheat file that downloads directly with the builds.
The only issue with this is if the player uses cheats for these two games, he will have to re-write them each time he makes ppsspp updates.

@sum2012
Copy link
Collaborator

sum2012 commented Jul 1, 2019

@unknownbrackets will test new signal handle in
#5999 (comment)
Maybe affect this game too

@unknownbrackets
Copy link
Collaborator

unknownbrackets commented Jul 7, 2019

With #12160, I'm able to complete the SC 2 demo, so I'm hopeful this is fixed by that change.

-[Unknown]

@unknownbrackets unknownbrackets added this to the v1.9.0 milestone Jul 7, 2019
@sum2012
Copy link
Collaborator

sum2012 commented Jul 7, 2019

Well done @unknownbrackets
Tested SC1 and SC2 are fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants