Optimize casts in softgpu #17618
Merged
Optimize casts in softgpu #17618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A number of these were falling back to some pretty terrible code. Thanks to fp64 for noticing.
Seems like a small benefit, but not seeing any issues from this. Noticed by fp64.
|
Regarding |
hrydgard
approved these changes
Jun 24, 2023
|
Probably + and * were just never used in a way that resulted in a crash so no one noticed (i.e. variables that weren't spilled or something.) Probably a bit dangerous... made a quick change. But I don't really want to burn too much time on x86_32, tbh, I have low hopes mainly due to core counts. -[Unknown] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just from the notes in #17613, thanks @fp64. I'm sometimes seeing about 2% improvement from this (mainly the cast, somewhere - maybe texture coords), which is pretty good.
-[Unknown]