Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding support for MPICH (instead of just MPICH2) #1098

Merged
merged 3 commits into from
Dec 10, 2014

Conversation

ebgregory
Copy link
Contributor

The naming convention for "MPICH3" is just just MPICH, so I added a line defining toolchain.MPICH.

@hpcugentbot
Copy link
Contributor

Automatic reply from Jenkins: Can I test this?

@boegel
Copy link
Member

boegel commented Nov 28, 2014

Jenkins: ok to test

@hpcugentbot
Copy link
Contributor

Test PASSed.

@boegel
Copy link
Member

boegel commented Dec 3, 2014

@ebgregory: some cleanup in ebgregory#1, looks good otherwise, and seems orthogonal with #1072, #1073 and #1101 by @ocaisa/@geimer

code cleanup in toolchain/mpi.py
@hpcugentbot
Copy link
Contributor

Test FAILed.

@boegel
Copy link
Member

boegel commented Dec 3, 2014

Jenkins: test this please

@hpcugentbot
Copy link
Contributor

Test PASSed.

@boegel
Copy link
Member

boegel commented Dec 10, 2014

Merging this is since it shouldn't have impact on existing builds, it simply makes sure the mpi_cmd_for function also works for toolchains using an MPI library from the MPICH MPI family.

Thanks @ebgregory!

boegel added a commit that referenced this pull request Dec 10, 2014
adding support for MPICH (instead of just MPICH2)
@boegel boegel merged commit 51d92b2 into easybuilders:develop Dec 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants