Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search Performance and UX, feature request: results paging #394

Open
foragerr opened this issue Apr 3, 2021 · 1 comment
Open

Search Performance and UX, feature request: results paging #394

foragerr opened this issue Apr 3, 2021 · 1 comment

Comments

@foragerr
Copy link

foragerr commented Apr 3, 2021

I have about 900 repos ( ~1M LoC ) indexed. Search performance is very variable. It feels fairly snappy when searching for larger specific strings with fewer matches; but is extremely slow for generic small snippet searches with lots of hits.

for example searching for foo in my setup returns 131,549ms total / 4,739ms server / 3477 files
The actual server side search is an impressive 4 seconds, but I see a spinner on the UI until the entire 154 MB of search results are transferred back - well over 2 mins! And then there's the bogged down browser from displaying all the results at once.

Paging and/or lazy loading would go a long way in improving user experience and perceived performance

@salemhilal
Copy link
Contributor

Hey! I agree, that's quite a lot of data to try and squeeze into the browser. I know we truncate results on a repo-by-repo basis, but it sounds like with 900 repos, paginating the repos themselves might be the right move. I think we would be open to a PR for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants