requestSubmit on safari incorrectly sets the submitter property on the SubmitEvent

[caleb]

I've been using Turbo Streams with a custom idiomorph action (though this bug occurs without idiomorph, see the sandbox below for a minimal example) and came across a bug with Turbo & Safari (tested on version 17) that might affect the upcoming refresh feature.

I have a form with multiple submit buttons that have different names, and some stimulus actions that submit the form via requestSubmit(). Clicking a button submits the form to the server and re-renders it with idiomorph., On Safari the requestSubmit form submissions will include the name/value of the previously used submit button.

So, if I submit the form with a submit button that is effect=add_distribution, then net time I submit the form with requestSubmit (regardless of whether I pass a submitter in or not, I tried adding a hidden submit button and specifying that), the previous effect=add_distribution parameter is sent to the server.

Firefox/Chrome work correctly and respect the submitter specified (or not) to requestSubmit

Anyway, for now I'm using the polyfill from Turbo regardless of whether the browser supports requestSubmit natively or not and that fixes the problem.

Just thought I'd bring it to your attention since people will be enjoying less javascript in Turbo 8 with idiomorph and refresh.

Here's a code sandbox showing the issue. If you comment out Turbo, the console shows the correct submitter, but with Turbo enabled, it uses the previous submitter.

[rik]

I see you've opened https://bugs.webkit.org/show_bug.cgi?id=265077, that's great!

[caleb]

Unfortunately I think I jumped the gun on that one, since it seems removing Turbo from being loaded makes Safari work correctly. I've resolved that issue for now, but would be willing to open another one if needed.

I had simply removed using turbo features explicitly, but was obviously still using it since it was being loaded.

[rik]

I think this is a dupe of #933. It just has not made it in a release yet.

[caleb]

Excellent! I can't believe I missed the PR, I searched for existing issues.

I'll give the master branch a try..

[rik]

You've got https://github.com/hotwired/dev-builds/tags as well.

[dbil25]

I also had opened this about a month ago but got no attention haha #1050

[caleb]

I think it will be fixed in the next version of turbo, for now you can grab their polyfill for requestSubmit and use that.