Remove Carthage and Cocoapods support #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@svara Can you give this a spot check and see if you have any feedback? I'm in favor of dropping Carthage and Cocoapods now that things have moved on to SPM. |
svara
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
Looks good 👍🏻
Great job on moving everything to SPM, and replacing GCDWebServer with Swifter @joemasilotti!
|
Thanks @svara! Merging in now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes Carthage and Cocoapods support and focuses entirely on the Swift Package Manager (SPM). It also means that
.xcworkspaceand.xcodeprojfiles are no longer needed!The test dependency, GCDWebServer, set up a local server to ensure HTTP requests are handled correctly via
Session. Unfortunately, it doesn't support SPM and was archived in January. I converted the dependency to [Swifter].I consider this PR ready for review/merge. But the test suite has a few things that could be improved in future PRs:
try!from test suite and addthrowsto test casesXCTUnwrapin place of multilineguardstatements in test suite