Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase turbo:load event timeout to 30 seconds #132

Merged
merged 2 commits into from
Jul 18, 2023

Conversation

olivaresf
Copy link
Member

@olivaresf olivaresf commented Jul 17, 2023

Internally, we've noted that the timeout is too short in some cases, e.g. slower connections, which may cause pageLoadFailed() to be triggered prematurely. Specifically, loading many import map javascript resources through es-module-shims can trigger the turbo:load event to trigger well after document.readyState == "complete".

For now, we suspect that increasing this time out will alleviate some of those scenarios. This is an follow-up to changes made in: #52

@olivaresf olivaresf requested a review from jayohms July 17, 2023 21:49
@olivaresf olivaresf changed the title Increase timeout to 10 seconds Increase timeout to 30 seconds Jul 18, 2023
@jayohms jayohms changed the title Increase timeout to 30 seconds Increase turbo:load event timeout to 30 seconds Jul 18, 2023
@jayohms jayohms changed the title Increase turbo:load event timeout to 30 seconds Increase turbo:load event timeout to 30 seconds Jul 18, 2023
@olivaresf olivaresf merged commit d938602 into webview-improvements Jul 18, 2023
@olivaresf olivaresf deleted the increase-turbo-js-loading-timeout branch July 18, 2023 01:27
@olivaresf olivaresf mentioned this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants