Increase turbo:load event timeout to 30 seconds #132
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internally, we've noted that the timeout is too short in some cases, e.g. slower connections, which may cause
pageLoadFailed()
to be triggered prematurely. Specifically, loading many import map javascript resources throughes-module-shims
can trigger theturbo:load
event to trigger well afterdocument.readyState == "complete"
.For now, we suspect that increasing this time out will alleviate some of those scenarios. This is an follow-up to changes made in: #52