Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log message for didStartRequestForVisitWithIdentifier #126

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

p8
Copy link
Contributor

@p8 p8 commented Jun 9, 2023

The log message for the "didStartRequestForVisitWithIdentifier" hook incorrectly logs "didFinishRequestForVisitWithIdentifier".

The log message for the "didStartRequestForVisitWithIdentifier" hook
incorrectly logs "didFinishRequestForVisitWithIdentifier".
@joemasilotti
Copy link
Member

Great catch, thanks for the PR!

@joemasilotti joemasilotti merged commit dcab269 into hotwired:main Jun 9, 2023
@p8 p8 deleted the fix-logging branch June 9, 2023 15:56
@p8
Copy link
Contributor Author

p8 commented Jun 9, 2023

Thanks @joemasilotti

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants