-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for query parameters in the PathConfiguration #188
Comments
100%. There's no technical reason why they're different — except oversight. Let's align them. Since this is a potential change in behavior for existing path configuration files, we'll likely need to add a new configuration option to maintain the current behavior. |
@leonvogt, let me know if you're open to submitting a PR. If not, I'm happy to take a pass myself. |
@jayohms thanks for the fast reply! @joemasilotti if this PR goes in a different direction than you intended, I'm happy to close it in favor of your approach. |
Currently, a PathConfiguration that captures certain URL parameters, such as:
works out of the box in Turbo-Android but not in Turbo-iOS.
There is a comment in the properties implementation that says query parameters are not supported yet but likely will be in the future.
Is there a technical reason why this was not implemented yet?
Before creating a PR, I wanted ask what the reasons were for this decision and what we need to consider when implementing this feature.
It would be nice if Turbo-iOS and Turbo-Android would behave the same way in this regard.
Thanks!
The text was updated successfully, but these errors were encountered: