From 5c15abbb7bcb41f0d95c8c5fb50e87929baef316 Mon Sep 17 00:00:00 2001 From: Darlington02 Date: Sun, 2 Feb 2025 20:16:14 +0100 Subject: [PATCH] chore: make follow and community nfts non-upgradeable --- src/community/communitynft.cairo | 11 +---------- src/follownft/follownft.cairo | 11 +---------- src/interfaces/ICustomNFT.cairo | 3 +-- src/interfaces/IFollowNFT.cairo | 3 +-- 4 files changed, 4 insertions(+), 24 deletions(-) diff --git a/src/community/communitynft.cairo b/src/community/communitynft.cairo index 9d15b7b..afd63b5 100644 --- a/src/community/communitynft.cairo +++ b/src/community/communitynft.cairo @@ -3,7 +3,7 @@ pub mod CommunityNFT { // ************************************************************************* // IMPORTS // ************************************************************************* - use starknet::{ContractAddress, ClassHash, get_block_timestamp}; + use starknet::{ContractAddress, get_block_timestamp}; use core::num::traits::zero::Zero; use openzeppelin_introspection::src5::SRC5Component; use openzeppelin_token::erc721::{ERC721Component, ERC721HooksEmptyImpl}; @@ -117,15 +117,6 @@ pub mod CommunityNFT { self.user_token_id.write(user_address, 0); } - /// @notice upgrades the nft contract - /// @param new_class_hash classhash to upgrade to - fn upgrade(ref self: ContractState, new_class_hash: ClassHash) { - self.ownable.assert_only_owner(); - - // Replace the class hash upgrading the contract - self.upgradeable.upgrade(new_class_hash); - } - // ************************************************************************* // GETTERS // ************************************************************************* diff --git a/src/follownft/follownft.cairo b/src/follownft/follownft.cairo index 2e98c62..22ae23f 100644 --- a/src/follownft/follownft.cairo +++ b/src/follownft/follownft.cairo @@ -4,7 +4,7 @@ pub mod Follow { // IMPORT // ************************************************************************* use starknet::{ - ContractAddress, ClassHash, get_block_timestamp, + ContractAddress, get_block_timestamp, storage::{ StoragePointerWriteAccess, StoragePointerReadAccess, Map, StorageMapReadAccess, StorageMapWriteAccess @@ -244,15 +244,6 @@ pub mod Follow { return true; } - /// @notice upgrades the nft contract - /// @param new_class_hash classhash to upgrade to - fn upgrade(ref self: ContractState, new_class_hash: ClassHash) { - self.ownable.assert_only_owner(); - - // Replace the class hash upgrading the contract - self.upgradeable.upgrade(new_class_hash); - } - // ************************************************************************* // GETTERS // ************************************************************************* diff --git a/src/interfaces/ICustomNFT.cairo b/src/interfaces/ICustomNFT.cairo index 92f2525..079c021 100644 --- a/src/interfaces/ICustomNFT.cairo +++ b/src/interfaces/ICustomNFT.cairo @@ -1,4 +1,4 @@ -use starknet::{ContractAddress, ClassHash}; +use starknet::ContractAddress; // ************************************************************************* // INTERFACE of ICommunity NFT @@ -11,7 +11,6 @@ pub trait ICustomNFT { fn mint_nft(ref self: TState, user_address: ContractAddress) -> u256; fn burn_nft(ref self: TState, user_address: ContractAddress, token_id: u256); - fn upgrade(ref self: TState, new_class_hash: ClassHash); // ************************************************************************* // GETTERS diff --git a/src/interfaces/IFollowNFT.cairo b/src/interfaces/IFollowNFT.cairo index 84b0ff1..83d98fc 100644 --- a/src/interfaces/IFollowNFT.cairo +++ b/src/interfaces/IFollowNFT.cairo @@ -1,4 +1,4 @@ -use starknet::{ContractAddress, ClassHash}; +use starknet::ContractAddress; use coloniz::base::constants::types::FollowData; // ************************************************************************* @@ -13,7 +13,6 @@ pub trait IFollowNFT { fn unfollow(ref self: TState, unfollower_profile_address: ContractAddress); fn process_block(ref self: TState, follower_profile_address: ContractAddress) -> bool; fn process_unblock(ref self: TState, follower_profile_address: ContractAddress) -> bool; - fn upgrade(ref self: TState, new_class_hash: ClassHash); // ************************************************************************* // GETTERS // *************************************************************************