Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on a tax-less invoice the generated XML did not contain some values where they are expected:
it validates if I manually add some data:
ubl:Invoice.cac:TaxTotal.cbc:TaxAmount and twice the currencyID Attribute to ubl:Invoice.cac:TaxTotal.cac:TaxSubtotal.{cbc:TaxableAmount,cbc:TaxAmount}
Also fixed the forwarded parameteres on XmlDocumentReader:
the reference could only be given to $callbackElse, not the the $callback function
added the reference values to the $callbackElse as on .whenEquals()