Fix: Creates invalid xml when tax value is zero

horstoeko · Dec 20, 2024 · e6f8206 · e6f8206
1 parent 8054662
commit e6f8206
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/src/XmlConverterCiiToUbl.php b/src/XmlConverterCiiToUbl.php
@@ -1224,6 +1224,14 @@ function ($taxTotalAmountNode) {
                             'currencyID',
                             $taxTotalAmountNode->getAttribute('currencyID')
                         );
+                    },
+                    function() use ($invoiceHeaderSettlement) {
+                        $this->destination->elementWithAttribute(
+                            'cbc:TaxAmount',
+                            0.0,
+                            'currencyID',
+                            $this->source->queryValue('./ram:InvoiceCurrencyCode', $invoiceHeaderSettlement)
+                        );
                     }
                 );
 
@@ -1236,12 +1244,14 @@ function ($tradeTaxNode) use ($invoiceHeaderSettlement) {
                             $this->formatAmount($this->source->queryValue('./ram:BasisAmount', $tradeTaxNode)),
                             'currencyID',
                             $this->source->queryValue('./ram:SpecifiedTradeSettlementHeaderMonetarySummation/ram:TaxTotalAmount/@currencyID', $invoiceHeaderSettlement)
+                            ?? $this->source->queryValue('./ram:InvoiceCurrencyCode', $invoiceHeaderSettlement)
                         );
                         $this->destination->elementWithAttribute(
                             'cbc:TaxAmount',
                             $this->formatAmount($this->source->queryValue('./ram:CalculatedAmount', $tradeTaxNode)),
                             'currencyID',
                             $this->source->queryValue('./ram:SpecifiedTradeSettlementHeaderMonetarySummation/ram:TaxTotalAmount/@currencyID', $invoiceHeaderSettlement)
+                            ?? $this->source->queryValue('./ram:InvoiceCurrencyCode', $invoiceHeaderSettlement)
                         );
 
                         $this->destination->startElement('cac:TaxCategory');