Skip to content
This repository has been archived by the owner on Jul 14, 2022. It is now read-only.

Better Error Logs #8

Closed
athul opened this issue Feb 11, 2020 · 2 comments · Fixed by #10
Closed

Better Error Logs #8

athul opened this issue Feb 11, 2020 · 2 comments · Fixed by #10
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@athul
Copy link
Contributor

athul commented Feb 11, 2020

The Errors logs just shows Go's usual Panic Output. Maybe we could wrap an abstraction for that. Like
Request Error or Check the URL/URI and Authentication
@athul athul added enhancement New feature or request good first issue Good for newcomers labels Feb 11, 2020
@gbmor
Copy link
Contributor

gbmor commented Feb 12, 2020

I have this working. Errors are bubbling up instead of panicking, and some of them have added context to the error. I'll wait till PR #9 is finished and merged, before I open a PR.

@athul
Copy link
Contributor Author

athul commented Feb 13, 2020

🤩

@gbmor gbmor mentioned this issue Feb 13, 2020
Merged
@athul athul linked a pull request Feb 13, 2020 that will close this issue
Error bubbling and Better JSON output #10
Merged
@gbmor gbmor closed this as completed in #10 Feb 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Error bubbling and Better JSON output hoppscotch/hopp-cli
2 participants
@gbmor @athul