Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid URL escape \"%2F\" #143

Closed
kramuenke opened this issue Sep 19, 2024 · 2 comments
Closed

invalid URL escape \"%2F\" #143

kramuenke opened this issue Sep 19, 2024 · 2 comments
Labels
status: oncall Flagged for awareness from Honeycomb Telemetry Oncall type: bug Something isn't working

Comments

@kramuenke
Copy link

kramuenke commented Sep 19, 2024

When passing an exporter endpoint including a path the config can not parse the url.

Versions

1.17

Steps to reproduce

Use a config like this:

otelShudown, err := otelconfig.ConfigureOpenTelemetry(
   otelconfig.WithServiceName("my-server"),
   otelconfig.WithExporterEndpoint("https://myproxy.com/otlp"),
   otelconfig.WithExporterProtocol(otelconfig.ProtocolHTTPProto),
)

produces the following error:

error: traces export: parse \"https://myproxy.com%2Fotlp/v1/traces\": invalid URL escape \"%2F\"

Additional context
We are using an http proxy to send our traces to honeycomb as we want to keep honeycomb api keys in one place.

@kramuenke kramuenke added the type: bug Something isn't working label Sep 19, 2024
@kramuenke
Copy link
Author

Suggestion to fix:

split the endpoint here when it has an extra path and use otlptracehttp.WithURLPath. Or provide the same functionality via your own config.

@TylerHelmuth TylerHelmuth added the status: oncall Flagged for awareness from Honeycomb Telemetry Oncall label Sep 19, 2024
@JamieDanielson
Copy link
Contributor

From what I can tell this is a duplicate of the problems described in #94 and it may require a larger change which is still on our backlog. If I have that wrong please feel free to comment on here to reopen the issue.

@JamieDanielson JamieDanielson closed this as not planned Won't fix, can't repro, duplicate, stale Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: oncall Flagged for awareness from Honeycomb Telemetry Oncall type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants