From a25604faa73a348575b151ddecc26a950ee1f754 Mon Sep 17 00:00:00 2001 From: Glen Mailer Date: Fri, 21 Oct 2022 19:32:01 +0100 Subject: [PATCH] Convert stray fmt.Printf into logger.Printf (#203) ## Which problem is this PR solving? - There's a stray `fmt.Printf` line in `transmission.go` ## Short description of the changes - I've converted it into a logger line, but I'm not sure if this is intentionally left in or not --- transmission/transmission.go | 2 +- transmission/transmission_test.go | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/transmission/transmission.go b/transmission/transmission.go index 572b98b..169821f 100644 --- a/transmission/transmission.go +++ b/transmission/transmission.go @@ -541,7 +541,7 @@ func (b *batchAgg) fireBatch(events []*Event) { for _, resp := range batchResponses { resp.Duration = dur / time.Duration(numEncoded) for eIdx < len(events) && events[eIdx] == nil { - fmt.Printf("incr, eIdx: %d, len(evs): %d\n", eIdx, len(events)) + b.logger.Printf("incr, eIdx: %d, len(evs): %d", eIdx, len(events)) eIdx++ } if eIdx == len(events) { // just in case diff --git a/transmission/transmission_test.go b/transmission/transmission_test.go index 9204599..199896e 100644 --- a/transmission/transmission_test.go +++ b/transmission/transmission_test.go @@ -817,6 +817,7 @@ func TestFireBatchWithBrokenFirstEvent(t *testing.T) { withJSONAndMsgpack(t, &doMsgpack, func(t *testing.T) { trt := &testRoundTripper{} b := &batchAgg{ + logger: &nullLogger{}, httpClient: &http.Client{Transport: trt}, testNower: &fakeNower{}, testBlocker: &sync.WaitGroup{}, @@ -864,6 +865,7 @@ func TestFireBatchWithBrokenMiddleEvent(t *testing.T) { runEvents := func(ev ...*Event) { trt := &testRoundTripper{} b := &batchAgg{ + logger: &nullLogger{}, httpClient: &http.Client{Transport: trt}, testNower: &fakeNower{}, // testBlocker: &sync.WaitGroup{},