Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"An OTLP empty request (a request that does not carry any telemetry data) SHOULD respond with success." #257

Open
kentquirk opened this issue Apr 12, 2024 · 0 comments
Labels
type: bug Something isn't working

Comments

@kentquirk
Copy link
Contributor

From the OTel spec:

If the server receives an empty request (a request that does not carry any telemetry data) the server SHOULD respond with success.

Honeycomb responds with 400: Request body should not be empty

Additional context
Reported by a customer.

❯ curl -i https://api.honeycomb.io/v1/traces -H "Content-Type: application/json" -H "x-honeycomb-team: $HC_KEY" -X POST -d '{}'
HTTP/1.1 200 OK
Connection: close

HTTP/1.1 400 Bad Request
Date: Thu, 11 Apr 2024 03:09:42 GMT
Content-Type: application/json
Content-Length: 46
Connection: keep-alive
Access-Control-Allow-Origin: *
Vary: Accept-Encoding

{"message":"request body should not be empty"}%     


❯ curl -i http://localhost:4318/v1/traces -X POST -H "Content-Type: application/json" -d '{}'
HTTP/1.1 200 OK
Content-Type: application/json
Date: Thu, 11 Apr 2024 03:09:51 GMT
Content-Length: 21

{"partialSuccess":{}}%    
@kentquirk kentquirk added the type: bug Something isn't working label Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant