Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deterministic Sampler tests are flaky #122

Closed
tredman opened this issue Oct 25, 2018 · 2 comments
Closed

Deterministic Sampler tests are flaky #122

tredman opened this issue Oct 25, 2018 · 2 comments

Comments

@tredman
Copy link
Contributor

tredman commented Oct 25, 2018

Could be an actual problem with the sampler:

--- FAIL: TestDeterministicSampler (3.17s)
    deterministic_sampler_test.go:85: Sampled more or less than we should have:  1895 (sample rate  100 )
@nathanleclaire
Copy link
Contributor

Heh... so close. 1900 is the cutoff -

200,000 events / 100 sample rate => 2000 sampled events * 0.95 margin of error => 1900

@vreynolds
Copy link
Contributor

Not seeing recent failures, but we've seen this in other projects: honeycombio/beeline-go#289

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nathanleclaire @tredman @vreynolds