Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup plugin does not upload source maps to staging environments #1408

Closed
mgreca opened this issue Oct 15, 2024 · 2 comments · Fixed by #1412
Closed

Rollup plugin does not upload source maps to staging environments #1408

mgreca opened this issue Oct 15, 2024 · 2 comments · Fixed by #1412
Assignees

Comments

@mgreca
Copy link

mgreca commented Oct 15, 2024

What are the steps to reproduce this issue?

  1. Create a vite application
  2. Install @honeybadger-io/rollup-plugin
  3. Try to build in other environments different than production

What happens?

Source maps are not uploaded if the environment is not "production".
The plugin is checking if NODE_ENV === "production" in this line . If it is not production, it won't upload source maps.

What were you expecting to happen?

It should upload to all environments except the development environments like dev, development or test. In my case, I need to upload to staging

What versions are you using?

Package Name: @honeybadger-io/rollup-plugin
Package Version: 5.9.3

@subzero10
Copy link
Member

Hey @mgreca, thank you for submitting an issue.
I've created #1412 to address your issue. It's pending review, but it should be merged soon.

@subzero10
Copy link
Member

@mgreca @honeybadger-io/rollup-plugn@5.10.0 includes an option to configure development environments to decide whether source maps should be updated or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants