Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

homebridge-ngbs-icon-thermostat #581

Closed
peterrakolcza opened this issue Oct 24, 2023 · 21 comments
Closed

homebridge-ngbs-icon-thermostat #581

peterrakolcza opened this issue Oct 24, 2023 · 21 comments
Labels
verified use when a plugin meets the criteria - adds the verified badge text

Comments

@peterrakolcza
Copy link

Link To GitHub Repo

https://github.com/peterrakolcza/homebridge-ngbs-icon-thermostat

Link To NPM Package

https://www.npmjs.com/package/homebridge-ngbs-icon-thermostat
@peterrakolcza peterrakolcza added the pending the label given to a new verification/icon request label Oct 24, 2023
@github-actions
Copy link

The following pre-checks failed:

❌ Failed to test plugin.
❌ Command failed: docker run --rm -e HOMEBRIDGE_PLUGIN_NAME=homebridge-ngbs-icon-thermostat -v /home/runner/work/verified/verified/precheck/results:/results check

Comment /check to run checks again.

@peterrakolcza
Copy link
Author

/check

@github-actions
Copy link

The following pre-checks failed:

❌ Failed to test plugin.
❌ Command failed: docker run --rm -e HOMEBRIDGE_PLUGIN_NAME=homebridge-ngbs-icon-thermostat -v /home/runner/work/verified/verified/precheck/results:/results check

Comment /check to run checks again.

@bwp91
Copy link
Contributor

bwp91 commented Oct 25, 2023

/check

@github-actions
Copy link

The following pre-checks failed:

❌ Failed to test plugin.
❌ Command failed: docker run --rm -e HOMEBRIDGE_PLUGIN_NAME=homebridge-ngbs-icon-thermostat -v /home/runner/work/verified/verified/precheck/results:/results check

Comment /check to run checks again.

@bwp91
Copy link
Contributor

bwp91 commented Oct 27, 2023

/check

@github-actions
Copy link

✅ Pre-checks completed successfully.

@peterrakolcza
Copy link
Author

/check

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2023

✅ Pre-checks completed successfully.

@donavanbecker donavanbecker added currently-reviewing use for starting a review - adds a comment with the verification list with empty checkboxes and removed pending the label given to a new verification/icon request labels Nov 10, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 10, 2023 •
edited by donavanbecker
Loading

  • - The plugin must successfully install.
  • - The plugin must implement the Homebridge Plugin Settings GUI.
  • - The plugin must not start unless it is configured.
  • - The plugin must be of type dynamic platform.
  • - The plugin must not offer the same nor less functionality than that of any existing verified plugin.
  • - The plugin must not execute post-install scripts that modify the user's system in any way.
  • - The plugin must not contain any analytics or calls that enable you to track the user.
  • - The plugin must not throw unhandled exceptions, the plugin must catch and log its own errors.
  • - The plugin must be published to npm and the source code available on GitHub.
  • - A GitHub release should be created for every new version of your plugin, with patch notes.
  • - The plugin must run on all Active LTS versions of Node.js, at the time of writing this is Node v18 and v20.
  • - The plugin must not require the user to run Homebridge in a TTY or with non-standard startup parameters, even for initial configuration.
  • - If the plugin needs to write files to disk (cache, keys, etc.), it must store them inside the Homebridge storage directory.
[NGBSiCONThermostat] Failed to login and connect to the client: 
<!DOCTYPE html>
<html lang="en">

<head>
    <meta charset="UTF-8">
    <meta http-equiv="X-UA-Compatible" content="IE=edge">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
    <title>www.enzoldhazam.hu - Bejelentkezés</title>
    <link rel="icon" type="image/png" href="favicon.png">
    <link rel="preconnect" href="https://fonts.googleapis.com">
    <link rel="preconnect" href="https://fonts.gstatic.com" crossorigin>
    <link href="https://fonts.googleapis.com/css2?family=Quicksand:wght@300;400;500;600;700&display=swap" rel="stylesheet">
    <link rel='stylesheet' href='Pages/css/style.css'><link rel='stylesheet' href='https://cdnjs.cloudflare.com/ajax/libs/font-awesome/6.1.1/css/all.min.css'></head>

<body><div class='ngbs_logo_container'><img src='Pages/assets/ngbslogo_black.png'></div><div class='main_form_container'><form id="login_form" class="dyn_app_form" action="/" method="POST">
    <div class="form_field">
        <input placeholder="E-mail/Felhasználónév" name="username" type="email" value="donavan.becker@icloud.com">
    </div>
        <div class="form_field">
        <input placeholder="Jelszó" name="password" type="password" value="12345">

    </div>
        <input type="hidden" name="token" value="3733343130383039343133363031363436393332393637343334343430343638373130">
    <input type="hidden" name="x-email" value="">
    <button type="submit">Bejelentkezés</button>
            <small class="error">Hibás felhasználónév, vagy jelszó!</small>
        
</form>
<div class="dyn_app_form_links">
    <a href="/registration">Regisztráció</a>
    <a href="/reset">Jelszó emlékeztető</a>
</div></div><div class="dyn_app_form_links dyn_app_form_links--bottom">
    <a target="_blank" href="https://www.ngbsh.hu/hu/">ngbs.hu</a>
    <a href="/privacy">Adatvédelem</a>
    <a href="/helpdesk">Helpdesk</a>
    <a href="/docs">Dokumentumok</a>
    <div class="dyn_app_copyright_text">Copyright © 2021 NGBS Hungary Kft. Minden jog fenntartva. </div>
</div><script src='Pages/js/utils.js'></script></body>

</html>
[11/9/2023, 8:22:38 PM] [HB Supervisor] Homebridge Process Ended. Code: 1, Signal: null

Comment /check to run checks again.

@donavanbecker donavanbecker added awaiting-user-reply use after review has started - awaiting user to reply to a comment and removed currently-reviewing use for starting a review - adds a comment with the verification list with empty checkboxes labels Nov 10, 2023
@peterrakolcza
Copy link
Author

peterrakolcza commented Nov 10, 2023 •
edited
Loading

An account is required with thermostats registered to use this plugint.

This error is thrown when invalid or no user credentials are configured. Thus, it returns the login page.

@donavanbecker
Copy link
Contributor

@peterrakolcza, totally understand that. You have to catch the error though so it doesn't cause homebridge to restart.

@peterrakolcza
Copy link
Author

After catching the error what should the plugin do? Just log the error and that's it?

@donavanbecker
Copy link
Contributor

That is what most plugins do. Say something like, check your credentials or something like that.

@donavanbecker donavanbecker added awaiting-changes use after review has started - awaiting user to make changes to plugin and removed awaiting-user-reply use after review has started - awaiting user to reply to a comment labels Nov 10, 2023
@peterrakolcza
Copy link
Author

/check

@github-actions github-actions bot added pending the label given to a new verification/icon request and removed awaiting-changes use after review has started - awaiting user to make changes to plugin labels Nov 10, 2023
@github-actions GitHub Actions
Copy link

✅ Pre-checks completed successfully.

@peterrakolcza
Copy link
Author

I have fixed the above mentioned issues.

@donavanbecker donavanbecker added verified use when a plugin meets the criteria - adds the verified badge text and removed pending the label given to a new verification/icon request labels Nov 10, 2023
@donavanbecker
Copy link
Contributor

/check

@github-actions github-actions bot added the pending the label given to a new verification/icon request label Nov 10, 2023
@github-actions github-actions bot removed the verified use when a plugin meets the criteria - adds the verified badge text label Nov 10, 2023
@github-actions GitHub Actions
Copy link

✅ Pre-checks completed successfully.

@donavanbecker donavanbecker added verified use when a plugin meets the criteria - adds the verified badge text and removed pending the label given to a new verification/icon request labels Nov 10, 2023
@github-actions GitHub Actions
Copy link

Congratulations! Your plugin has been verified.

You can now add one of the Verified by Homebridge badges to your plugin's README:

verified-by-homebridge

[![verified-by-homebridge](https://badgen.net/badge/homebridge/verified/purple)](https://github.com/homebridge/homebridge/wiki/Verified-Plugins)

verified-by-homebridge

[![verified-by-homebridge](https://img.shields.io/badge/homebridge-verified-blueviolet?color=%23491F59&style=for-the-badge&logoColor=%23FFFFFF&logo=homebridge)](https://github.com/homebridge/homebridge/wiki/Verified-Plugins)

Your plugin is now also eligible to display a ❤️ Donate button on its tile in the Homebridge UI. See https://github.com/homebridge/homebridge/wiki/Donation-Links for instructions.

If for any reason in the future you can no longer maintain your plugin, please consider transferring it to our unmaintained plugins repo. We can take ownership until another willing developer comes along.

Don't forget to join the official Homebridge Discord server, where plugin developers can get tips and advice from other developers and the Homebridge project team in the #plugin-development channel!

Thank you for your contribution to the Homebridge Community.
https://homebridge.io

@homebridge homebridge deleted a comment from github-actions bot Nov 10, 2023
@donavanbecker donavanbecker reopened this Nov 10, 2023
@bwp91
Copy link
Contributor

bwp91 commented Nov 18, 2023

Congrats

@bwp91 bwp91 closed this as completed Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
verified use when a plugin meets the criteria - adds the verified badge text
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@peterrakolcza @donavanbecker @bwp91