Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check config script #23151

Merged
merged 3 commits into from
Apr 17, 2019
Merged

Fix check config script #23151

merged 3 commits into from
Apr 17, 2019

Conversation

balloob
Copy link
Member

@balloob balloob commented Apr 16, 2019

Description:

Fix check_config script being called from the async_check_config service call.

This is quite gross tbh, we should not have the core rely on anything that is inside a script. The script also has side effects like clearing the secret cache, and shares a lot of code with homeassistant.config.async_process_component_config

Related issue (if applicable): fixes #23114

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob requested review from kellerza and a team as code owners April 16, 2019 22:04
@homeassistant homeassistant added cla-signed core small-pr PRs with less than 30 lines. labels Apr 16, 2019
@awarecan
Copy link
Contributor

1000% agreed.

@codecov

This comment has been minimized.

@codecov
Copy link

codecov bot commented Apr 16, 2019

Codecov Report

Merging #23151 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev   #23151      +/-   ##
=========================================
+ Coverage   94.2%   94.21%   +<.01%     
=========================================
  Files        453      453              
  Lines      36909    36909              
=========================================
+ Hits       34769    34772       +3     
+ Misses      2140     2137       -3
Impacted Files Coverage Δ
homeassistant/config.py 93.01% <100%> (ø) ⬆️
...ssistant/components/islamic_prayer_times/sensor.py 97.87% <0%> (+3.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e02a5f0...570fdde. Read the comment docs.

@awarecan awarecan merged commit 37ca9ca into dev Apr 17, 2019
@delete-merged-branch delete-merged-branch bot deleted the check-config-script branch April 17, 2019 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed core small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing services and traceback messages on dev branch triggered on restart
3 participants