Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix ZHA device_removed() handler. #23074

Merged
merged 1 commit into from
Apr 13, 2019
Merged

Bugfix ZHA device_removed() handler. #23074

merged 1 commit into from
Apr 13, 2019

Conversation

Adminiuga
Copy link
Contributor

Description:

Bugfix ZHA device_removed() handler.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly (example).
  • New dependencies have been added to requirements in the manifest (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

@ghost ghost assigned Adminiuga Apr 13, 2019
@ghost ghost added the in progress label Apr 13, 2019
@github-actions
Copy link

Hey there @dmulcahey, mind taking a look at this pull request as its been labeled with a integration (zha) you are listed as a codeowner for? Thanks!

dmulcahey
dmulcahey approved these changes Apr 13, 2019
View reviewed changes
Copy link
Contributor

@dmulcahey dmulcahey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can merge when build passes

@dmulcahey dmulcahey merged commit 479511e into home-assistant:dev Apr 13, 2019
@ghost ghost removed the in progress label Apr 13, 2019
@Adminiuga Adminiuga deleted the fixes/zha-device-remove branch June 3, 2019 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmulcahey dmulcahey dmulcahey approved these changes

Assignees

@dmulcahey dmulcahey

@Adminiuga Adminiuga

Labels
cla-signed integration: zha small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Adminiuga @dmulcahey @homeassistant