-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support HEOS devices not logged in to HEOS account #22913
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #22913 +/- ##
=======================================
Coverage 93.83% 93.83%
=======================================
Files 448 448
Lines 36578 36578
=======================================
Hits 34324 34324
Misses 2254 2254
Continue to review full report at Codecov.
|
controller.get_favorites(), | ||
controller.get_input_sources() | ||
) | ||
players = await controller.get_players() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could still gather this and controller.get_input_sources
, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could, but it doesn't materially improve performance as there's still only 1 underlying telnet connection to the controller and these commands respond instantaneously. I kept it separate to increase readability of the flow, but can gather it back up if desired.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, it's fine. I'll always comment on awaiting in "loops", since sometimes it does make a difference.
Description:
Adds support for connecting to HEOS devices that are not logged in to the user's HEOS account. All control features are still available, with the exception of loading favorites into source selection. A warning message is printed in the log upon startup when the device is not logged in. Prior to this change, the HEOS config entry would fail to load.
This PR also fixes a data-type issue in
async_set_volume_level
that resulted in a failure to set the volume level to 0.Checklist:
tox
. Your PR cannot be merged unless tests passIf the code does not interact with devices: