Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure OpenUV service checks permissions #22668

Merged
merged 3 commits into from
Apr 13, 2019

Conversation

bachya
Copy link
Contributor

@bachya bachya commented Apr 2, 2019

Description:

This PR should not be merged until #22667 is merged.

This PR ensures that the openuv.update_data service properly checks user permissions.

Related issue (if applicable): N/A

Pull request in home-assistant.io with documentation (if applicable): N/A

Example entry for configuration.yaml (if applicable):

N/A

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@bachya bachya self-assigned this Apr 2, 2019
@bachya bachya requested a review from a team as a code owner April 2, 2019 22:08
@ghost ghost added the in progress label Apr 2, 2019
@bachya bachya removed the request for review from a team April 2, 2019 22:08
@bachya bachya changed the title Ensure OpenUV service checks permissions WIP: Ensure OpenUV service checks permissions Apr 2, 2019
@bachya bachya force-pushed the protect-openuv-service branch 4 times, most recently from a306456 to 7ed5e30 Compare April 3, 2019 12:15
@bachya bachya force-pushed the protect-openuv-service branch 4 times, most recently from 5d3acbe to dc71fbf Compare April 13, 2019 20:53
@bachya bachya changed the title WIP: Ensure OpenUV service checks permissions Ensure OpenUV service checks permissions Apr 13, 2019
@bachya bachya added the small-pr PRs with less than 30 lines. label Apr 13, 2019
@bachya bachya force-pushed the protect-openuv-service branch from d6ad354 to 553e1c6 Compare April 13, 2019 21:32
@bachya bachya merged commit 56b08a6 into home-assistant:dev Apr 13, 2019
@ghost ghost removed the in progress label Apr 13, 2019
@bachya bachya deleted the protect-openuv-service branch April 13, 2019 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants