Admin service to automatically add empty schema #22637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
cla-signed
core
integration: cloud
small-pr
houndci-bot
reviewed
Apr 1, 2019
ghost
assigned
4 tasks
houndci-bot
reviewed
Apr 1, 2019
| def async_register_admin_service( | ||
| hass: typing.HomeAssistantType, domain: str, | ||
| service: str, service_func: Callable, | ||
| schema: vol.Schema = vol.Schema({}, extra=vol.PREVENT_EXTRA)) -> None: |
There was a problem hiding this comment.
missing whitespace around parameter equals
unibeck
pushed a commit
to unibeck/home-assistant
that referenced
this pull request
Apr 7, 2019
* Admin service to automatically add empty schema * Lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Don't require services without a schema to define one, instead just add a schema.
Per discussion #22609 (comment)
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: