Add google hangouts manual authentication option #22158
Conversation
ghost
added
the
|
Could you confirm whether you still need username/password if you choose to use manual login method. Actually, in my opinion, the auth_code way is better than save Google account password in HA. |
No, need for username/password using the manual login. Thought about removing them but I figured perhaps it might still work for some people so decided to leave it in. Side question though, does the password get saved in HA ?? I had thought only the refresh token would be saved. |
|
Aha, you are right, password is not saved. |
|
Hey @awarecan, any idea on when/if this would get merged (or if there are any issues with it) ? |
| self._credentials, | ||
| self._refresh_token) | ||
| if user_auth_code is None: | ||
| manual_login = False |
There was a problem hiding this comment.
manual_login = user_auth_code is not None
MartinHjelmare
changed the title
teliov
requested review from
Adminiuga,
amelchio,
andrewsayre,
andrey-git,
emlove,
bachya,
balloob,
cdce8p,
cgtobi,
Danielhiversen,
dgomes,
dmulcahey,
fabaff,
frenck and
Kane610
as code owners
awarecan
removed request for
a team,
robbiet480,
OverloadUT,
bachya,
scop,
fabaff,
dgomes,
frenck,
Danielhiversen,
cdce8p,
Adminiuga,
amelchio,
andrewsayre,
andrey-git,
emlove,
balloob,
cgtobi,
dmulcahey,
Kane610,
kellerza,
ludeeus,
OttoWinter,
rohankapoorcom,
rytilahti and
syssi
* Added option to use manual authentication for google hangout component See: https://hangups.readthedocs.io/en/latest/user_guide.html#logging-in for manual log in example Bumped up version of hangups to 0.4.9 * Updated components/hangouts/strings.json and generated translation string by running script/translations_develop Reduced verbosity of modifications to components/hangouts/config_flow.py * Added option to use manual authentication for google hangout component See: https://hangups.readthedocs.io/en/latest/user_guide.html#logging-in for manual log in example Bumped up version of hangups to 0.4.9 * Updated components/hangouts/strings.json and generated translation string by running script/translations_develop Reduced verbosity of modifications to components/hangouts/config_flow.py * fixing missing rebase
See: https://hangups.readthedocs.io/en/latest/user_guide.html#logging-in for manual log in example
Bumped up version of hangups to 0.4.9
Description:
Authentication for the google hangout component fails even with correct auth credentials. The underlying library (hangups) which powers this component was updated to provide a manual authentication option. This PR provides an implementation of this update.
It allows the user to supply a manually obtained authorization code during setup which is then used to authenticate.
Related issue (if applicable): fixes #17705
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8974
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py.If the code does not interact with devices: