Improve evohome exception handling and fix bugs #22140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
houndci-bot
reviewed
Mar 17, 2019
fabaff
changed the title
zxdavb
changed the title
zxdavb
changed the title
zxdavb
changed the title
|
Sorry @MartinHjelmare, my undoing of your edit was just a cross-post. |
|
@MartinHjelmare Do you have time to look at this please? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Can be merged when build passes. |
Thanks Martin - I always have a sense of great achievement when I get something past you! 😄 |
|
@MartinHjelmare Merge please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change:
No breaking changes I am aware of.
Description:
Upgrade to the latest client library (improved exception handling, support for reusing sessions/tokens) - this needed a minor update to
climate\honeywell.py.Improve exception handling: widen number of exceptions caught, improve log messages.
BUGFIX: Fix issue Coding error in evohome -
call service climate/turn_onfails #22097: Failed to call service climate/turn_on...BUGFIX: handle case where a Zone doesn't have a temperature
BUGFIX: missing exception handler, and removed inappropriate delint hints
Use less aggressive throttling when the API rate limit has been exceeded
Related issue (if applicable): fixes #22097
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Not applicable
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed: Not applicable
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: Not applicable