-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic Supla cover support #22133
Conversation
Hi @mwegrzynek, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
Please add a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Fix the two remaining comments, and I think we can merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
I think you need to run the script/manifest/codeowners.py
to update codeowners file.
Can be merged when build passes.
Hooray! :) Thanks for all the patient coaching and code checking! |
Codecov Report
@@ Coverage Diff @@
## dev #22133 +/- ##
==========================================
- Coverage 93.85% 93.85% -0.01%
==========================================
Files 449 449
Lines 36765 36765
==========================================
- Hits 34507 34505 -2
- Misses 2258 2260 +2
Continue to review full report at Codecov.
|
Breaking Change:
Description:
New platform for Supla (https://www.supla.org) IoT components with covers support as a first step.
Related issue (if applicable): fixes #
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8971
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTS
variable (example).requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.If the code does not interact with devices: