Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic Supla cover support #22133

Merged
merged 18 commits into from
Apr 15, 2019
Merged

Add basic Supla cover support #22133

merged 18 commits into from
Apr 15, 2019

Conversation

mwegrzynek
Copy link
Contributor

@mwegrzynek mwegrzynek commented Mar 17, 2019

Breaking Change:

Description:

New platform for Supla (https://www.supla.org) IoT components with covers support as a first step.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8971

Example entry for configuration.yaml (if applicable):

supla:
    servers:
        - server: srv1.supla.org
          access_token: <really long access token you can get from integrations menu in Supla's web UI>

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@homeassistant
Copy link
Contributor

Hi @mwegrzynek,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@mwegrzynek mwegrzynek marked this pull request as ready for review March 17, 2019 20:44
@fabaff fabaff changed the title Added basic Supla (https://www.supla.org) support (covers) Added basic Supla cover support Mar 18, 2019
homeassistant/components/supla/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/supla/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/supla/__init__.py Show resolved Hide resolved
homeassistant/components/supla/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/supla/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/supla/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/supla/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/supla/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/supla/cover.py Outdated Show resolved Hide resolved
homeassistant/components/supla/__init__.py Outdated Show resolved Hide resolved
@MartinHjelmare MartinHjelmare changed the title Added basic Supla cover support Add basic Supla cover support Apr 9, 2019
@MartinHjelmare
Copy link
Member

Please add a manifest.json file under the integration component package. See other integrations for examples.

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Fix the two remaining comments, and I think we can merge.

homeassistant/components/supla/cover.py Show resolved Hide resolved
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

I think you need to run the script/manifest/codeowners.py to update codeowners file.

Can be merged when build passes.

@mwegrzynek
Copy link
Contributor Author

Nice!

I think you need to run the script/manifest/codeowners.py to update codeowners file.

Can be merged when build passes.

Hooray! :) Thanks for all the patient coaching and code checking!

@codecov
Copy link

codecov bot commented Apr 11, 2019

Codecov Report

Merging #22133 into dev will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #22133      +/-   ##
==========================================
- Coverage   93.85%   93.85%   -0.01%     
==========================================
  Files         449      449              
  Lines       36765    36765              
==========================================
- Hits        34507    34505       -2     
- Misses       2258     2260       +2
Impacted Files Coverage Δ
...ssistant/components/islamic_prayer_times/sensor.py 94.73% <0%> (-3.16%) ⬇️
homeassistant/components/uk_transport/sensor.py 94.16% <0%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4e31bc...1c97906. Read the comment docs.

@balloob balloob merged commit 7251e29 into home-assistant:dev Apr 15, 2019
@ghost ghost removed the in progress label Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants