Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial Fibaro HC Climate support #20256

Merged
merged 24 commits into from
Apr 9, 2019
Merged

Initial Fibaro HC Climate support #20256

merged 24 commits into from
Apr 9, 2019

Conversation

pbalogh77
Copy link
Contributor

@pbalogh77 pbalogh77 commented Jan 19, 2019 •
edited by frenck
Loading

Description:

Initial support for climate platform for the Fibaro hub integration.

Related issue (if applicable): fixes #19359

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8748

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

@ghost ghost added the in progress label Jan 19, 2019
@pbalogh77 pbalogh77 changed the title WIP: Initial Fibaro HC Climate support Initial Fibaro HC Climate support Jan 20, 2019
@pbalogh77 pbalogh77 changed the title Initial Fibaro HC Climate support WIP: Initial Fibaro HC Climate support Jan 20, 2019
@pbalogh77 pbalogh77 changed the title WIP: Initial Fibaro HC Climate support Initial Fibaro HC Climate support Jan 20, 2019
@frenck
Copy link
Member

frenck commented Jan 21, 2019

⚠️ I was unable to find a documentation PR (matching this code change) in our documentation repository.

📚Please, update the documentation and open a PR for it (be sure to create a documentation PR against the next branch) and link 🔗 this PR and the new documentation PR by mentioning the link to the PR's in both openings posts/descriptions.

🏷 I am adding the docs-missing label until this has been resolved.

👍 Thanks (times a million!)

houndci-bot
houndci-bot reviewed Jan 25, 2019
View reviewed changes
homeassistant/components/climate/fibaro.py Outdated Show resolved Hide resolved
homeassistant/components/climate/fibaro.py Outdated Show resolved Hide resolved
homeassistant/components/climate/fibaro.py Outdated Show resolved Hide resolved
homeassistant/components/climate/fibaro.py Outdated Show resolved Hide resolved
homeassistant/components/climate/fibaro.py Outdated Show resolved Hide resolved
homeassistant/components/climate/fibaro.py Outdated Show resolved Hide resolved
homeassistant/components/climate/fibaro.py Outdated Show resolved Hide resolved
homeassistant/components/climate/fibaro.py Outdated Show resolved Hide resolved
@elbogi
Copy link

elbogi commented Feb 19, 2019

Any progress on this PR, or anything that the community could do to help this get into the next RC?

@pbalogh77
Copy link
Contributor Author

Docs PR: home-assistant/home-assistant.io#8748

@pbalogh77 pbalogh77 mentioned this pull request Feb 27, 2019
Closed
2 tasks
MartinHjelmare
MartinHjelmare requested changes Mar 23, 2019
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please git mv the fibaro climate platform to the fibaro component package. That's our new way of structuring integrations.

homeassistant/components/fibaro/climate.py

homeassistant/components/climate/fibaro.py Outdated Show resolved Hide resolved
homeassistant/components/climate/fibaro.py Outdated Show resolved Hide resolved
homeassistant/components/climate/fibaro.py Outdated Show resolved Hide resolved
homeassistant/components/climate/fibaro.py Outdated Show resolved Hide resolved
homeassistant/components/climate/fibaro.py Outdated Show resolved Hide resolved
homeassistant/components/climate/fibaro.py Outdated Show resolved Hide resolved
homeassistant/components/climate/fibaro.py Outdated Show resolved Hide resolved
homeassistant/components/climate/fibaro.py Outdated Show resolved Hide resolved
homeassistant/components/climate/fibaro.py Outdated Show resolved Hide resolved
homeassistant/components/fibaro/__init__.py Outdated Show resolved Hide resolved
pbalogh77 added 11 commits April 6, 2019 17:24
@pbalogh77
Reworked detection mechanism
c7adeec 
Better support for combined devices
@pbalogh77
Added additional modes
0373a90
@pbalogh77
force visibility on climate
10196e9
@pbalogh77
Changed logging of device data
b472d4f
@pbalogh77
Improved operatingmode support
1070740 
Improved operatingmode support
@pbalogh77
Updated logic for opmode/fanmode list creation
5298d20 
Implemented a universal mapping logic for opmode and fanmode, to make it more widely compatible
Improved mapping of Fibaro FGT devices
@pbalogh77
Lint fixes
a486d1a
@pbalogh77
bump
cf793c2
@pbalogh77
Fixes based on code review
bb2b683
@pbalogh77
Fixes
0cf4393
@pbalogh77
Moved to fibaro folder
3a29302
pbalogh77 added 2 commits April 7, 2019 22:55
@pbalogh77
Mapped all operating modes to existing HA ones
774f0a9 
Mapped all operating modes to existing HA ones
@pbalogh77
Improved compatibility with Heatit thermostats
c6f2597 
Thanks to astrandb for testing, debugging and fixing my code
@pbalogh77
Changes based on code review
3b7eb8c 
Changes based on code review
MartinHjelmare
MartinHjelmare approved these changes Apr 8, 2019
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged when last comments are addressed and build passes.

homeassistant/components/fibaro/climate.py Outdated Show resolved Hide resolved
homeassistant/components/fibaro/climate.py Outdated Show resolved Hide resolved
@pbalogh77
more fixes based on more code review
dc3d8ba 
more fixes based on more code review
@MartinHjelmare MartinHjelmare merged commit 1a05f7b into home-assistant:dev Apr 9, 2019
@ghost ghost removed the in progress label Apr 9, 2019
@pbalogh77 pbalogh77 deleted the climate branch April 9, 2019 05:57
@klaasnicolaas klaasnicolaas mentioned this pull request May 8, 2019
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
cla-signed integration: fibaro new-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fibaro platform: climate device issue
8 participants
@pbalogh77 @frenck @elbogi @MartinHjelmare @houndci-bot @robbiet480 @homeassistant @amelchio