Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump axis to v58 #114008

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Bump axis to v58 #114008

merged 1 commit into from
Mar 22, 2024

Conversation

Kane610
Copy link
Member

@Kane610 Kane610 commented Mar 22, 2024

Breaking change

Proposed change

Kane610/axis@v57...v58
Handle more missing Image parameters on certain devices

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Kane610 👍

../Frenck

@Kane610
Copy link
Member Author

Kane610 commented Mar 22, 2024

Thanks @joostlek @frenck 🎉

@frenck frenck merged commit c6f2ff8 into home-assistant:dev Mar 22, 2024
35 checks passed
frenck pushed a commit that referenced this pull request Mar 22, 2024
@frenck frenck mentioned this pull request Mar 22, 2024
@Kane610 Kane610 deleted the axis-bump_to_v58 branch March 22, 2024 16:55
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to reconfigure axis cameras in 2024.3.2 Various Exceptions Loading Axis integration in 2024.3.1
3 participants