-
-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stream zoom functionality #1117
Comments
There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. |
Functionality still needed. |
So looks like to support something like this similar to what iOS does we may need to add some scaling options to App Configuration to handle this. Looking at Webview docs I think we may need to use: https://developer.android.com/reference/android/webkit/WebView#setInitialScale(int) For those seeing this issue please note this isn't just to zoom on a particular card or video stream, its to zoom into the entire HA frontend. |
I think it won't be the best solution, as you said it will zoom into the whole frontend, but if it works I am in!
And a similar issues is also open for the frontend: home-assistant/frontend#6612 Unfortunately I am currently still don't have enough time to investigate it further. |
@uvjustin is something that can be supported by exoplayer and the app? You appear to be our expert in this area :) I dont believe scaling the WebView will be helpful here right? |
I think zooming along with the webview might be difficult and require a big refactor. Zooming into the video when ExoPlayer is fullscreen seems like it would be easier to do and would seem to satisfy the use case. I'll try look into it some more when I get a chance. |
@uvjustin any progress on this? Pinch to zoom for video feeds would be fantastic! |
Hey all we just had #2252 deployed and I think that will satisfy this feature request, could someone please try the latest beta found on github to see if pinch to zoom is what was needed here? |
@dshokouhi yessss!! Just tried it out, works perfectly so far! Will update if any bugs. Thank you, I love this feature!! 🥳 |
Thanks everyone. It seems to be working perfectly. :) |
Is your feature request related to a problem? Please describe.
I have multiple camera streams with high resolution. The new exoplayer working correctly displaying the H.265 stream which is great, as it does not work in the browser.
The only remaining problem is that I can't zoom into the camera view, which makes the cameras almost useless, as I can't see the details.
I tried with the new 0.117.0 which enables zooming, but it only works in the browser.
Describe the solution you'd like
I would like to zoom to the stream components / camera live views.
Describe alternatives you've considered, if any
There is no alternative, as the browser can't play the H.265 stream, and the app can't zoom in.
Additional context
I also tried enabling zoom with:
which zooms correctly, but the exoplayer layer won't follow the zoom.
The text was updated successfully, but these errors were encountered: