Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(groups): add home board settings #2321

Merged
merged 14 commits into from
Feb 15, 2025
Merged

Conversation

Meierschlumpf
Copy link
Member

@Meierschlumpf Meierschlumpf commented Feb 13, 2025


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

Todos:

  • Add home board selection when loading it
  • Add saving of priorities
  • Add screenshots
  • Test mysql / sqlite migration from before to now with ROW_NUMBER()

Closes #2250

image

image

image

@Meierschlumpf Meierschlumpf self-assigned this Feb 13, 2025
@Meierschlumpf Meierschlumpf added the enhancement New feature or request label Feb 13, 2025
Copy link

deepsource-io bot commented Feb 13, 2025

Here's the code health analysis summary for commits a38afb0..1db9880. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ Success
🎯 2 occurences resolved
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

github-actions bot commented Feb 13, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 21.52% 8813 / 40945
🔵 Statements 21.52% 8813 / 40945
🔵 Functions 26.96% 346 / 1283
🔵 Branches 62.2% 1004 / 1614
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
apps/nextjs/src/app/[locale]/manage/settings/_components/board-settings-form.tsx 0% 0% 0% 0% 1-51
apps/nextjs/src/app/[locale]/manage/users/[userId]/general/page.tsx 0% 0% 0% 0% 1-131
apps/nextjs/src/app/[locale]/manage/users/[userId]/general/_components/_change-home-board.tsx 0% 0% 0% 0% 1-85
apps/nextjs/src/app/[locale]/manage/users/groups/_client.tsx 0% 0% 0% 0% 1-65
apps/nextjs/src/app/[locale]/manage/users/groups/_groups-table.tsx 0% 0% 0% 0% 1-277
apps/nextjs/src/app/[locale]/manage/users/groups/page.tsx 0% 0% 0% 0% 1-58
apps/nextjs/src/app/[locale]/manage/users/groups/[id]/layout.tsx 0% 0% 0% 0% 1-69
apps/nextjs/src/app/[locale]/manage/users/groups/[id]/settings/_group-home-boards.tsx 0% 0% 0% 0% 1-81
apps/nextjs/src/app/[locale]/manage/users/groups/[id]/settings/page.tsx 0% 0% 0% 0% 1-41
apps/nextjs/src/components/board/board-select.tsx 0% 0% 0% 0% 1-33
e2e/shared/actions/onboarding-actions.ts 0% 0% 0% 0% 1-54
packages/api/src/router/board.ts 58.63% 77.18% 75% 58.63% 41-49, 52-59, 65-90, 166-235, 244-260, 291-416, 435-439, 452-454, 457-459, 467, 533-677, 887, 906, 917-932, 937-938, 960-975, 980-981, 1000-1002, 1027-1029, 1130-1134, 1167-1168
packages/api/src/router/group.ts 70.99% 91.89% 100% 70.99% 17-37, 133-155, 166-173, 179-195, 235-243, 249-266, 319-323, 361-365
packages/api/src/router/user.ts 47.07% 63.63% 100% 47.07% 88-95, 113-148, 156-164, 172-179, 192-205, 228-259, 268-272, 280-284, 287-291, 312-316, 325-384, 391-428, 447-450, 457, 464-469, 475-487, 495-521, 553-557
packages/db/migrations/seed.ts 0% 0% 0% 0% 1-82
packages/db/queries/group.ts 100% 100% 100% 100%
packages/db/queries/index.ts 100% 100% 100% 100%
packages/db/schema/mysql.ts 100% 100% 100% 100%
packages/db/schema/sqlite.ts 100% 100% 100% 100%
packages/old-import/src/import/collections/user-collection.ts 4.65% 100% 0% 4.65% 10-61
packages/ui/src/components/index.tsx 0% 0% 0% 0% 1
packages/ui/src/components/select-with-custom-items.tsx 0% 0% 0% 0% 1-96
packages/validation/src/group.ts 100% 100% 100% 100%
Generated in workflow #5105 for commit 1db9880 by the Vitest Coverage Report Action

@Meierschlumpf Meierschlumpf marked this pull request as ready for review February 14, 2025 18:10
@Meierschlumpf Meierschlumpf requested a review from a team as a code owner February 14, 2025 18:10
@Meierschlumpf Meierschlumpf merged commit 7b479e5 into dev Feb 15, 2025
14 checks passed
@Meierschlumpf Meierschlumpf deleted the group-settings-home-board branch February 15, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: home board for groups
2 participants