Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty env variables should be ignored #2040

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

Meierschlumpf
Copy link
Member


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

Closes #1984

@Meierschlumpf Meierschlumpf added the bug Something isn't working label Jan 21, 2025
@Meierschlumpf Meierschlumpf self-assigned this Jan 21, 2025
@Meierschlumpf Meierschlumpf requested a review from a team as a code owner January 21, 2025 09:34
Copy link

deepsource-io bot commented Jan 21, 2025

Here's the code health analysis summary for commits 243d7e9..6a95d0f. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ Success
🎯 2 occurences resolved
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

github-actions bot commented Jan 21, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 21.29% 8403 / 39457
🔵 Statements 21.29% 8403 / 39457
🔵 Functions 25.49% 312 / 1224
🔵 Branches 62.27% 951 / 1527
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
apps/nextjs/src/env.ts 0% 0% 0% 0% 1-39
packages/auth/env.ts 57.83% 0% 100% 57.83% 11-21, 34-43, 46-59
packages/common/env.ts 100% 100% 100% 100%
packages/db/env.ts 73.07% 16.66% 100% 73.07% 33, 36, 38-49
Generated in workflow #4700 for commit 6a95d0f by the Vitest Coverage Report Action

@Meierschlumpf Meierschlumpf merged commit 1759279 into dev Jan 21, 2025
13 checks passed
@Meierschlumpf Meierschlumpf deleted the empty-string-as-undefined-env branch January 21, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: empty env variables should be ignored
1 participant