You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This issue is in two parts, one requiring an easy fix and a second part that is more involved.
When an exception occurs, the display hooks attempt to restore the option state using StoreOptions.state(element, state=optstate). When a DynamicMap is involved, this fails with StopIteration. This exception should be caught and silenced as StopIteration indicates there are no elements to traverse and therefore nothing to restore state on.
Actually restoring the option state on DynamicMaps properly. DynamicMap requires special handling as the option state is held on the container and dynamically propagated to the elements as they are generated. StoreOptions.state therefore needs to be DynamicMap aware to handle this restoration properly.
The text was updated successfully, but these errors were encountered:
The above PR (#848) addresses part 1. though not in the way I thought it would. Catching StopIteration wouldn't be a good solution as it would mean that the style restoration would stop as soon as it encountered a DynamicMap.
Part 2. above will need to be addressed in a separate PR.
That depends on when 1.7 is ready: as soon as we have proper integration with Bokeh events, I feel we should release. This particular issue shouldn't block 1.7 but I would like to tackle it before then if I have time.
This issue is in two parts, one requiring an easy fix and a second part that is more involved.
StoreOptions.state(element, state=optstate)
. When aDynamicMap
is involved, this fails withStopIteration
. This exception should be caught and silenced asStopIteration
indicates there are no elements to traverse and therefore nothing to restore state on.DynamicMaps
properly.DynamicMap
requires special handling as the option state is held on the container and dynamically propagated to the elements as they are generated.StoreOptions.state
therefore needs to beDynamicMap
aware to handle this restoration properly.The text was updated successfully, but these errors were encountered: