We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
holoviews==1.19.1
I would like to try out the new pop up form with HoloViews and Panel.
Unfortunately the user experience of the Panel reference example in https://holoviews.org/user_guide/Custom_Interactivity.html is pretty bad if you choose to close the form by clicking the close button.
close
When you select some other datapoints the description will be hidden.
import panel as pn import numpy as np import holoviews as hv pn.extension() def popup_form(index): def hide_popup(_): layout.visible = False if not index: return df = points.iloc[index].dframe().describe() button = pn.widgets.Button(name="Close", sizing_mode="stretch_width") layout = pn.Column(button, df) button.on_click(hide_popup) return layout points = hv.Points(np.random.randn(1000, 2)) hv.streams.Selection1D(source=points, popup=popup_form) points.opts( tools=["box_select", "lasso_select", "tap"], active_tools=["lasso_select"], size=6, color="black", fill_color=None, width=500, height=500 ) pn.panel(points).servable()
The text was updated successfully, but these errors were encountered:
I experience the same behavior with the example from the original PR
import panel as pn import numpy as np import holoviews as hv hv.extension("bokeh") points = hv.Points(np.random.randn(1000, 2)) def form(name): text_input = pn.widgets.TextInput(name='Description') button = pn.widgets.Button(name='Save', on_click=lambda _: layout.param.update(visible=False)) layout = pn.Column(f'# {name}', text_input, button) return layout hv.streams.BoundsXY(source=points, popup=form('Bounds')) hv.streams.Lasso(source=points, popup=form('Lasso')) hv.streams.Tap(source=points, popup=form('Tap')) pn.panel(points.opts(tools=['box_select', 'lasso_select', 'tap'], width=600, height=600, size=6, color='black', fill_color=None)).servable()
Once you've clicked save once you cannot open/ see the pop up again.
Sorry, something went wrong.
I believe the cause is where marked below.
If there is an invisible _existing_popup the new pop up will new become an element of the panel. I don't understand why.
_existing_popup
@ahuang11 ?
ahuang11
Successfully merging a pull request may close this issue.
holoviews==1.19.1
I would like to try out the new pop up form with HoloViews and Panel.
Unfortunately the user experience of the Panel reference example in https://holoviews.org/user_guide/Custom_Interactivity.html is pretty bad if you choose to
close
the form by clicking theclose
button.When you select some other datapoints the description will be hidden.
The text was updated successfully, but these errors were encountered: